[PATCH] drm/i915: Modify spinlocks while reading pipe crc
Mika Kahola
mika.kahola at intel.com
Fri Apr 21 13:23:26 UTC 2017
Let's try to shuffle spinlock acquiring/releasing while reading
out pipe crc. This is a fix for
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100367
Signed-off-by: Mika Kahola <mika.kahola at intel.com>
---
drivers/gpu/drm/i915/intel_pipe_crc.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c
index 647426c..de1bf5f 100644
--- a/drivers/gpu/drm/i915/intel_pipe_crc.c
+++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
@@ -146,15 +146,13 @@ i915_pipe_crc_read(struct file *filep, char __user *user_buf, size_t count,
entry->crc[1], entry->crc[2],
entry->crc[3], entry->crc[4]);
- spin_unlock_irq(&pipe_crc->lock);
-
- if (copy_to_user(user_buf, buf, PIPE_CRC_LINE_LEN))
+ if (copy_to_user(user_buf, buf, PIPE_CRC_LINE_LEN)) {
+ spin_unlock_irq(&pipe_crc->lock);
return -EFAULT;
+ }
user_buf += PIPE_CRC_LINE_LEN;
n_entries--;
-
- spin_lock_irq(&pipe_crc->lock);
}
spin_unlock_irq(&pipe_crc->lock);
--
2.7.4
More information about the Intel-gfx-trybot
mailing list