[PATCH 1/2] drm/i915: Introduce intel_alternate_aux_to_port.

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Aug 3 16:51:19 UTC 2017


Let's create a separated function to map the VBT alternate
aux into our enum port so that can be used also for other
cases.

Cc: Jani Nikula <jani.nikula at intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 37 ++++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 19 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 2d42d09428c9..ca6a9b646bb8 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1284,6 +1284,23 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
 	return ret;
 }
 
+static enum port intel_alternate_aux_to_port(uint8_t alternate_aux)
+{
+	switch (alternate_aux) {
+	case DP_AUX_A:
+		return PORT_A;
+	case DP_AUX_B:
+		return PORT_B;
+	case DP_AUX_C:
+		return PORT_C;
+	case DP_AUX_D:
+		return PORT_D;
+	default:
+		MISSING_CASE(alternate_aux);
+		return PORT_A;
+	}
+}
+
 static enum port intel_aux_port(struct drm_i915_private *dev_priv,
 				enum port port)
 {
@@ -1297,25 +1314,7 @@ static enum port intel_aux_port(struct drm_i915_private *dev_priv,
 		return port;
 	}
 
-	switch (info->alternate_aux_channel) {
-	case DP_AUX_A:
-		aux_port = PORT_A;
-		break;
-	case DP_AUX_B:
-		aux_port = PORT_B;
-		break;
-	case DP_AUX_C:
-		aux_port = PORT_C;
-		break;
-	case DP_AUX_D:
-		aux_port = PORT_D;
-		break;
-	default:
-		MISSING_CASE(info->alternate_aux_channel);
-		aux_port = PORT_A;
-		break;
-	}
-
+	aux_port = intel_alternate_aux_to_port(info->alternate_aux_channel);
 	DRM_DEBUG_KMS("using AUX %c for port %c (VBT)\n",
 		      port_name(aux_port), port_name(port));
 
-- 
2.13.2



More information about the Intel-gfx-trybot mailing list