[PATCH] drm/i915: Track pinned vma in intel_plane_state

[Maarten Lankhorst]

Op 04-01-17 om 10:49 schreef Chris Wilson:
> On Wed, Jan 04, 2017 at 08:33:43AM +0100, Maarten Lankhorst wrote:
>> From: Chris Wilson <chris at chris-wilson.co.uk>
>>
>> With atomic plane states we are able to track an allocation right from
>> preparation, during use and through to the final free after being
>> swapped out for a new plane. We can couple the VMA we pin for the
>> framebuffer (and its rotation) to this lifetime and avoid all the clumsy
>> lookups in between.
>>
>> v2: Remove residual vma on plane cleanup (Chris)
>> v3: Add WARN_ON(vma) to intel_plane_destroy_state (Maarten)
> Iirc, if we inherit plane state from the BIOS and never do a modeset,
> the residual plane state has a vma.
> -Chris
>
We suck in that case, but as part of re-enabling atomic rmfb I was cleaning it up by
doing a disable all crtc in driver unload. Our hardware readout sucks for more advanced
cases than the bios leaves us with. If I fix that to disable all planes too
then this won't be needed.

I think it's better not to keep this waiting on atomic rmfb, so I'll remove the WARN_ON
first for now, but also add a comment that this is required for driver unload.

~Maarten