[PATCH 14/87] drm/i915: Name the anonymous structs inside i915_ggtt_view

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Jan 6 13:03:29 UTC 2017


On 05/01/2017 23:19, Chris Wilson wrote:
> Naming this pair will become useful later...
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.h | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
> index 9e91d7e6149c..19ea4c942df4 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.h
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
> @@ -149,20 +149,22 @@ enum i915_ggtt_view_type {
>  };
>
>  struct intel_rotation_info {
> -	struct {
> +	struct intel_rotation_plane_info {
>  		/* tiles */
>  		unsigned int width, height, stride, offset;
>  	} plane[2];
>  };
>
> +struct intel_partial_info {
> +	u64 offset;
> +	unsigned int size;
> +};
> +
>  struct i915_ggtt_view {
>  	enum i915_ggtt_view_type type;
>
>  	union {
> -		struct {
> -			u64 offset;
> -			unsigned int size;
> -		} partial;
> +		struct intel_partial_info partial;
>  		struct intel_rotation_info rotated;
>  	} params;
>  };
>

Haven't look forward but I trust you it will be useful.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx-trybot mailing list