[PATCH 2/3] drm/i915: Set adjustment to zero on Up/Down interrupts if freq is already max/min

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 17 11:19:37 UTC 2017


On Tue, Jan 17, 2017 at 04:09:27PM +0530, Sagar Arun Kamble wrote:
> From: "sagar.a.kamble at intel.com" <sagar.a.kamble at intel.com>

When we reach the user's RPS limits, stop requesting an adjustment. Even
though we will clamp the requested frequency later, we rely on interrupt
masking to disable further adjustments in the same direction. Even
though it is unlikely (one scenario is a bug in the driver, another is
careful manipulation through the uAPI) if we keep exponentially
increasing the adjustment value, it will wrap and cause a negative
adjustment.
 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>

Care to give a reviewed-by?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx-trybot mailing list