[PATCH 2/4] drm/i915: s/pm_intr_keep/intr_keep_unmasked
Chris Wilson
chris at chris-wilson.co.uk
Fri Mar 10 17:26:53 UTC 2017
On Fri, Mar 10, 2017 at 10:22:26PM +0530, Sagar Arun Kamble wrote:
> "pm_intr_keep" is not conveying the intent that it is bitmask
> of interrupts that are to be kept unmasked(cleared) in GEN6_PMINTRMSK.
> Name it "intr_keep_unmasked".
It should still be pm_intr_* to follow the nearby convention of pm_reg.
pm_intr_keep_unmasked is better.
How about pm_intr_never? Or pm_intr_mbz; Hmm, it's cryptic but I think
mbz is the most descriptive one yet.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx-trybot
mailing list