[PATCH 01/12] drm/i915: Kill another user of intel_crtc->active.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Tue Mar 21 12:55:20 UTC 2017


When disabling lcpll all crtc's should be disabled.
For this reason it should be safe to use active_crtcs,
no updates are expected until wake locks are taken.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 010e5ddb198a..68154a84420b 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -8643,12 +8643,11 @@ static bool ironlake_get_pipe_config(struct intel_crtc *crtc,
 
 static void assert_can_disable_lcpll(struct drm_i915_private *dev_priv)
 {
-	struct drm_device *dev = &dev_priv->drm;
-	struct intel_crtc *crtc;
+	enum pipe pipe;
 
-	for_each_intel_crtc(dev, crtc)
-		I915_STATE_WARN(crtc->active, "CRTC for pipe %c enabled\n",
-		     pipe_name(crtc->pipe));
+	for_each_pipe(dev_priv, pipe)
+		I915_STATE_WARN(dev_priv->active_crtcs & (1 << pipe),
+				"CRTC for pipe %c enabled\n", pipe_name(pipe));
 
 	I915_STATE_WARN(I915_READ(HSW_PWR_WELL_DRIVER), "Power well on\n");
 	I915_STATE_WARN(I915_READ(SPLL_CTL) & SPLL_PLL_ENABLE, "SPLL enabled\n");
-- 
2.7.4



More information about the Intel-gfx-trybot mailing list