[PATCH 05/12] drm/i915/guc: Fix GuC interrupts disabling with Logging
Sagar Arun Kamble
sagar.a.kamble at intel.com
Wed Nov 1 17:29:25 UTC 2017
With guc_log_unregister disabling runtime logging and interrupts, there
is no need to disable interrupts during uc_fini_hw hence it is removed.
With GuC CT buffer mechanism, interrupt disabling can be added at a point
where CT mechanism ceases.
v2: Moved this patch earlier in the series. (Tvrtko)
Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
---
drivers/gpu/drm/i915/intel_uc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index bd2fc5b..1157602 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -290,10 +290,8 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
guc_disable_communication(&dev_priv->guc);
- if (i915_modparams.enable_guc_submission) {
- intel_disable_guc_interrupts(&dev_priv->guc);
+ if (i915_modparams.enable_guc_submission)
i915_guc_submission_fini(dev_priv);
- }
i915_ggtt_disable_guc(dev_priv);
}
--
1.9.1
More information about the Intel-gfx-trybot
mailing list