[PATCH 8/9] drm/i915/guc: Update enable_guc_loading check in uc_fini_hw

Sagar Arun Kamble sagar.a.kamble at intel.com
Fri Oct 13 11:28:49 UTC 2017


With most of the GuC related disabling/cleanup in uc_fini_hw now
separated from GuC parameters, only task that needs GuC parameter
enable_guc_loading check is of disabling guc ggtt invalidatation
as that is enabled based on enable_guc_loading. So call only
disable_guc_ggtt when enable_guc_loading is set during uc_fini_hw.

v2: Rebase. Commit message update.

Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: MichaƂ Winiarski <michal.winiarski at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 1ff3823..7195180 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -270,14 +270,12 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
 
 	guc_free_load_err_log(guc);
 
-	if (!i915_modparams.enable_guc_loading)
-		return;
-
 	i915_guc_submission_disable(dev_priv);
 
 	guc_disable_communication(guc);
 
 	i915_guc_submission_fini(dev_priv);
 
-	i915_ggtt_disable_guc(dev_priv);
+	if (i915_modparams.enable_guc_loading)
+		i915_ggtt_disable_guc(dev_priv);
 }
-- 
1.9.1



More information about the Intel-gfx-trybot mailing list