[PATCH v14 09/25] drm/i915/guc: Fix GuC interrupts disabling with Logging

Sagar Arun Kamble sagar.a.kamble at intel.com
Tue Oct 17 10:36:58 UTC 2017

With guc_log_unregister disabling runtime logging and interrupts there
is no need to disable interrupts during uc_fini_hw hence it is removed.
With GuC CT buffer mechanism, interrupt disabling can be added at a point
where CT mechanism ceases.

Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
 drivers/gpu/drm/i915/intel_uc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 11a82d1..5ecb94e 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -287,9 +287,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
-	if (i915_modparams.guc_log_level >= 0)
-		intel_put_guc_interrupts(&dev_priv->guc, GUC_INTR_CLIENT_LOG);
 	if (i915_modparams.enable_guc_submission)

More information about the Intel-gfx-trybot mailing list