[PATCH 12/15] ubsan 2
Tvrtko Ursulin
tursulin at ursulin.net
Thu Oct 19 17:48:43 UTC 2017
From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
[ 129.966110] ================================================================================
[ 129.966166] UBSAN: Undefined behaviour in drivers/iommu/dmar.c:1345:3
[ 129.966192] shift exponent 64 is too large for 32-bit type 'int'
[ 129.966218] CPU: 2 PID: 1167 Comm: perf_pmu Not tainted 4.14.0-rc5+ #532
[ 129.966221] Hardware name: LENOVO 80MX/Lenovo E31-80, BIOS DCCN34WW(V2.03) 12/01/2015
[ 129.966224] Call Trace:
[ 129.966227] <IRQ>
[ 129.966236] dump_stack+0xab/0xfe
[ 129.966253] ? _atomic_dec_and_lock+0x112/0x112
[ 129.966271] ? get_unsigned_val+0x48/0x91
[ 129.966276] ubsan_epilogue+0x9/0x49
[ 129.966281] __ubsan_handle_shift_out_of_bounds+0x1ea/0x241
[ 129.966286] ? __ubsan_handle_load_invalid_value+0x136/0x136
[ 129.966291] ? _raw_spin_unlock_irqrestore+0x32/0x50
[ 129.966297] ? qi_submit_sync+0x642/0x820
[ 129.966302] ? qi_flush_dev_iotlb+0x158/0x1b0
[ 129.966307] qi_flush_dev_iotlb+0x158/0x1b0
[ 129.966311] ? qi_flush_iotlb+0x110/0x110
[ 129.966317] ? do_raw_spin_lock+0x93/0x130
[ 129.966321] iommu_flush_dev_iotlb+0xff/0x170
[ 129.966325] iommu_flush_iova+0x168/0x220
[ 129.966330] iova_domain_flush+0x2b/0x50
[ 129.966334] fq_flush_timeout+0xa6/0x1e0
[ 129.966339] ? fq_ring_free+0x260/0x260
[ 129.966343] ? call_timer_fn+0xfd/0x600
[ 129.966347] call_timer_fn+0x160/0x600
[ 129.966352] ? fq_ring_free+0x260/0x260
[ 129.966355] ? trace_timer_cancel+0x1d0/0x1d0
[ 129.966360] ? _raw_spin_unlock_irq+0x29/0x40
[ 129.966364] ? fq_ring_free+0x260/0x260
[ 129.966368] ? fq_ring_free+0x260/0x260
[ 129.966372] run_timer_softirq+0x3bb/0x9a0
[ 129.966377] ? timer_fixup_init+0x30/0x30
[ 129.966382] ? __lock_is_held+0x35/0x150
[ 129.966386] ? sched_clock_cpu+0x14/0x180
[ 129.966391] __do_softirq+0x159/0x9c7
[ 129.966396] irq_exit+0x118/0x170
[ 129.966401] smp_apic_timer_interrupt+0xda/0x530
[ 129.966405] apic_timer_interrupt+0x9d/0xb0
[ 129.966408] </IRQ>
[ 129.966413] RIP: 0010:__asan_load4+0xa/0x80
[ 129.966416] RSP: 0018:ffff88012f647380 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff10
[ 129.966423] RAX: ffff7fffffffffff RBX: ffff88012f647548 RCX: ffffffff9a07ea01
[ 129.966426] RDX: dffffc0000000000 RSI: ffff88012f647808 RDI: ffff88012f647548
[ 129.966430] RBP: ffff88012f640000 R08: fffffbfff3b27e96 R09: fffffbfff3b27e95
[ 129.966433] R10: ffffffff9d93f4ad R11: fffffbfff3b27e96 R12: ffff88012f648000
[ 129.966436] R13: ffff88012f647558 R14: ffff88012f647550 R15: ffff88012f647808
[ 129.966441] ? stack_access_ok+0x61/0x110
[ 129.966446] stack_access_ok+0x6d/0x110
[ 129.966451] deref_stack_reg+0x64/0x120
[ 129.966456] ? __read_once_size_nocheck.constprop.3+0x50/0x50
[ 129.966460] ? deref_stack_reg+0x120/0x120
[ 129.966464] ? __kmalloc+0x13a/0x550
[ 129.966468] unwind_next_frame+0xc04/0x14e0
[ 129.966472] ? kasan_kmalloc+0xa0/0xd0
[ 129.966476] ? __kmalloc+0x13a/0x550
[ 129.966480] ? __kmalloc+0x13a/0x550
[ 129.966484] ? deref_stack_reg+0x120/0x120
[ 129.966489] ? unwind_next_frame+0xf3e/0x14e0
[ 129.966550] ? i915_gem_do_execbuffer+0x4fd/0x2570 [i915]
[ 129.966555] __save_stack_trace+0x7a/0x120
[ 129.966560] ? __kmalloc+0x13a/0x550
[ 129.966564] save_stack+0x33/0xa0
[ 129.966569] ? save_stack+0x33/0xa0
[ 129.966573] ? kasan_kmalloc+0xa0/0xd0
[ 129.966579] ? _raw_spin_unlock+0x24/0x30
[ 129.966584] ? deactivate_slab+0x650/0xb90
[ 129.966590] ? ___slab_alloc+0x3e0/0x940
[ 129.966593] ? ___slab_alloc+0x3e0/0x940
[ 129.966656] ? i915_gem_do_execbuffer+0x4fd/0x2570 [i915]
[ 129.966661] ? __lock_is_held+0x35/0x150
[ 129.966665] ? mark_held_locks+0x33/0x130
[ 129.966670] ? kasan_unpoison_shadow+0x30/0x40
[ 129.966674] kasan_kmalloc+0xa0/0xd0
[ 129.966678] __kmalloc+0x13a/0x550
[ 129.966683] ? depot_save_stack+0x16a/0x7f0
[ 129.966743] i915_gem_do_execbuffer+0x4fd/0x2570 [i915]
[ 129.966748] ? save_stack+0x92/0xa0
[ 129.966808] ? eb_relocate_slow+0x890/0x890 [i915]
[ 129.966813] ? debug_check_no_locks_freed+0x200/0x200
[ 129.966818] ? ___slab_alloc+0x3e0/0x940
[ 129.966822] ? ___slab_alloc+0x3e0/0x940
[ 129.966882] ? i915_gem_execbuffer2+0xdb/0x5f0 [i915]
[ 129.966886] ? __lock_is_held+0x35/0x150
[ 129.966948] ? i915_gem_execbuffer+0x580/0x580 [i915]
[ 129.967009] i915_gem_execbuffer2+0x2c1/0x5f0 [i915]
[ 129.967070] ? i915_gem_execbuffer+0x580/0x580 [i915]
[ 129.967075] ? lock_downgrade+0x310/0x310
[ 129.967135] ? i915_gem_execbuffer+0x580/0x580 [i915]
[ 129.967139] drm_ioctl_kernel+0xdc/0x190
[ 129.967144] drm_ioctl+0x46a/0x6e0
[ 129.967204] ? i915_gem_execbuffer+0x580/0x580 [i915]
[ 129.967208] ? drm_setversion+0x430/0x430
[ 129.967213] ? lock_downgrade+0x310/0x310
[ 129.967219] do_vfs_ioctl+0x138/0xbf0
[ 129.967223] ? ioctl_preallocate+0x180/0x180
[ 129.967228] ? do_raw_spin_unlock+0xf5/0x1d0
[ 129.967232] ? do_raw_spin_trylock+0x90/0x90
[ 129.967237] ? task_work_run+0x35/0x120
[ 129.967241] ? mark_held_locks+0x33/0x130
[ 129.967246] ? _raw_spin_unlock_irq+0x29/0x40
[ 129.967250] ? mark_held_locks+0x33/0x130
[ 129.967255] ? entry_SYSCALL_64_fastpath+0x5/0xad
[ 129.967259] ? trace_hardirqs_on_caller+0x184/0x360
[ 129.967264] SyS_ioctl+0x3b/0x70
[ 129.967269] entry_SYSCALL_64_fastpath+0x18/0xad
[ 129.967272] RIP: 0033:0x7fc0e1f0d587
[ 129.967275] RSP: 002b:00007ffcfd9929f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[ 129.967282] RAX: ffffffffffffffda RBX: 0000000000000006 RCX: 00007fc0e1f0d587
[ 129.967285] RDX: 00007ffcfd992a90 RSI: 0000000040406469 RDI: 0000000000000003
[ 129.967288] RBP: 0000000000000003 R08: 00007ffcfd992a50 R09: 0000000000000000
[ 129.967291] R10: 0000000000000073 R11: 0000000000000246 R12: 0000000000000001
[ 129.967294] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
[ 129.967298] ================================================================================
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
drivers/iommu/dmar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 57c920c1372d..f8ea06745fc8 100644
--- a/drivers/iommu/dmar.c
+++ b/drivers/iommu/dmar.c
@@ -1342,7 +1342,7 @@ void qi_flush_dev_iotlb(struct intel_iommu *iommu, u16 sid, u16 qdep,
struct qi_desc desc;
if (mask) {
- BUG_ON(addr & ((1 << (VTD_PAGE_SHIFT + mask)) - 1));
+// BUG_ON(addr & ((1 << (VTD_PAGE_SHIFT + mask)) - 1));
addr |= (1ULL << (VTD_PAGE_SHIFT + mask - 1)) - 1;
desc.high = QI_DEV_IOTLB_ADDR(addr) | QI_DEV_IOTLB_SIZE;
} else
--
2.9.5
More information about the Intel-gfx-trybot
mailing list