[PATCH 74/74] fast-execbuf2-ioctl
Chris Wilson
chris at chris-wilson.co.uk
Thu Sep 14 17:34:48 UTC 2017
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 5 ++-
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 63 +++++++++++++++++++++++-------
3 files changed, 52 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 6629d7cef05d..7f6a13c015fa 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -2650,7 +2650,7 @@ static const struct drm_ioctl_desc i915_ioctls[] = {
DRM_IOCTL_DEF_DRV(I915_HWS_ADDR, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
DRM_IOCTL_DEF_DRV(I915_GEM_INIT, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY),
DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER, i915_gem_execbuffer, DRM_AUTH),
- DRM_IOCTL_DEF_DRV(I915_GEM_EXECBUFFER2_WR, i915_gem_execbuffer2, DRM_AUTH|DRM_RENDER_ALLOW),
+ DRM_DRIVER_IOCTL_DEF(I915_GEM_EXECBUFFER2_WR, i915_gem_execbuffer2_ioctl, DRM_AUTH|DRM_RENDER_ALLOW),
DRM_IOCTL_DEF_DRV(I915_GEM_PIN, i915_gem_reject_pin_ioctl, DRM_AUTH|DRM_ROOT_ONLY),
DRM_IOCTL_DEF_DRV(I915_GEM_UNPIN, i915_gem_reject_pin_ioctl, DRM_AUTH|DRM_ROOT_ONLY),
DRM_DRIVER_IOCTL_DEF(I915_GEM_BUSY, i915_gem_busy_ioctl, DRM_RENDER_ALLOW),
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 760bcddaf0e1..4c954ad59e6c 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -3417,8 +3417,9 @@ long i915_gem_sw_finish_ioctl(struct file *filp,
unsigned long data);
int i915_gem_execbuffer(struct drm_device *dev, void *data,
struct drm_file *file_priv);
-int i915_gem_execbuffer2(struct drm_device *dev, void *data,
- struct drm_file *file_priv);
+long i915_gem_execbuffer2_ioctl(struct file *filp,
+ unsigned int cmd,
+ unsigned long data);
long i915_gem_busy_ioctl(struct file *filp,
unsigned int cmd,
unsigned long arg);
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 2ace739ae71c..b2b0bd0eeeb4 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -2529,25 +2529,48 @@ i915_gem_execbuffer(struct drm_device *dev, void *data,
return err;
}
-int
-i915_gem_execbuffer2(struct drm_device *dev, void *data,
- struct drm_file *file)
+long
+i915_gem_execbuffer2_ioctl(struct file *filp,
+ unsigned int cmd,
+ unsigned long data)
{
const size_t sz = (sizeof(struct drm_i915_gem_exec_object2) +
sizeof(struct i915_vma *) +
sizeof(unsigned int));
- struct drm_i915_gem_execbuffer2 *args = data;
+ struct drm_i915_gem_execbuffer2 __user *user = (typeof(user))data;
+ struct drm_i915_gem_execbuffer2 arg;
struct drm_i915_gem_exec_object2 *exec2_list;
struct drm_syncobj **fences = NULL;
- const size_t count = args->buffer_count;
+ struct drm_file *file = filp->private_data;
+ size_t count;
int err;
+ if (unlikely(!(file->authenticated || drm_is_render_client(file))))
+ return -EACCES;
+
+ user_access_begin();
+ unsafe_get_user(arg.buffers_ptr, &user->buffers_ptr, err_user);
+ unsafe_get_user(arg.buffer_count, &user->buffer_count, err_user);
+ unsafe_get_user(arg.batch_start_offset,
+ &user->batch_start_offset, err_user);
+ unsafe_get_user(arg.batch_len, &user->batch_len, err_user);
+ unsafe_get_user(arg.DR1, &user->DR1, err_user);
+ unsafe_get_user(arg.DR4, &user->DR4, err_user);
+ unsafe_get_user(arg.num_cliprects, &user->num_cliprects, err_user);
+ unsafe_get_user(arg.cliprects_ptr, &user->cliprects_ptr, err_user);
+ unsafe_get_user(arg.flags, &user->flags, err_user);
+ unsafe_get_user(arg.rsvd1, &user->rsvd1, err_user);
+ unsafe_get_user(arg.rsvd2, &user->rsvd2, err_user);
+ user_access_end();
+
+ count = arg.buffer_count;
+
if (count < 1 || count > SIZE_MAX / sz - 1) {
DRM_DEBUG("execbuf2 with %zd buffers\n", count);
return -EINVAL;
}
- if (!i915_gem_check_execbuffer(args))
+ if (!i915_gem_check_execbuffer(&arg))
return -EINVAL;
/* Allocate an extra slot for use by the command parser */
@@ -2559,22 +2582,23 @@ i915_gem_execbuffer2(struct drm_device *dev, void *data,
return -ENOMEM;
}
if (copy_from_user(exec2_list,
- u64_to_user_ptr(args->buffers_ptr),
+ u64_to_user_ptr(arg.buffers_ptr),
sizeof(*exec2_list) * count)) {
DRM_DEBUG("copy %zd exec entries failed\n", count);
kvfree(exec2_list);
return -EFAULT;
}
- if (args->flags & I915_EXEC_FENCE_ARRAY) {
- fences = get_fence_array(args, file);
+ if (arg.flags & I915_EXEC_FENCE_ARRAY) {
+ fences = get_fence_array(&arg, file);
if (IS_ERR(fences)) {
kvfree(exec2_list);
return PTR_ERR(fences);
}
}
- err = i915_gem_do_execbuffer(dev, file, args, exec2_list, fences);
+ err = i915_gem_do_execbuffer(file->minor->dev, file, &arg,
+ exec2_list, fences);
/*
* Now that we have begun execution of the batchbuffer, we ignore
@@ -2582,14 +2606,14 @@ i915_gem_execbuffer2(struct drm_device *dev, void *data,
* updated the associated relocations, we try to write out the current
* object locations irrespective of any error.
*/
- if (args->flags & __EXEC_HAS_RELOC) {
+ if (arg.flags & __EXEC_HAS_RELOC) {
struct drm_i915_gem_exec_object2 __user *user_exec_list =
- u64_to_user_ptr(args->buffers_ptr);
+ u64_to_user_ptr(arg.buffers_ptr);
unsigned int i;
/* Copy the new buffer offsets back to the user's exec list. */
user_access_begin();
- for (i = 0; i < args->buffer_count; i++) {
+ for (i = 0; i < arg.buffer_count; i++) {
if (!(exec2_list[i].offset & UPDATE))
continue;
@@ -2603,8 +2627,17 @@ i915_gem_execbuffer2(struct drm_device *dev, void *data,
user_access_end();
}
- args->flags &= ~__I915_EXEC_UNKNOWN_FLAGS;
- put_fence_array(args, fences);
+ if (!err && arg.flags & I915_EXEC_FENCE_OUT) {
+ user_access_begin();
+ unsafe_put_user(arg.rsvd2, &user->rsvd2, ignore_error);
+ignore_error:
+ user_access_end();
+ }
+ put_fence_array(&arg, fences);
kvfree(exec2_list);
return err;
+
+err_user:
+ user_access_end();
+ return -EFAULT;
}
--
2.14.1
More information about the Intel-gfx-trybot
mailing list