[PATCH 2/2] drm/i915/guc: Update i915.enable_guc_loading check in intel_uc_fini_hw
Sagar Arun Kamble
sagar.a.kamble at intel.com
Thu Sep 28 16:34:02 UTC 2017
With most of the GuC disabling now separated from enable_guc_submission
parameter, only function that needs GuC parameter check is
i915_disable_guc_ggtt as that is enabled based on GuC kernel parameters.
Hence i915_disable_guc_ggtt is being called when enable_guc_loading is
set.
Signed-off-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: Michał Winiarski <michal.winiarski at intel.com>
---
drivers/gpu/drm/i915/intel_uc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index ecd020d..3efcf46 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -464,9 +464,6 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
{
guc_free_load_err_log(&dev_priv->guc);
- if (!i915_modparams.enable_guc_loading)
- return;
-
i915_guc_submission_disable(dev_priv);
guc_disable_communication(&dev_priv->guc);
@@ -474,7 +471,8 @@ void intel_uc_fini_hw(struct drm_i915_private *dev_priv)
gen9_disable_guc_interrupts(dev_priv);
i915_guc_submission_fini(dev_priv);
- i915_ggtt_disable_guc(dev_priv);
+ if (i915_modparams.enable_guc_loading)
+ i915_ggtt_disable_guc(dev_priv);
}
int intel_guc_send_nop(struct intel_guc *guc, const u32 *action, u32 len)
--
1.9.1
More information about the Intel-gfx-trybot
mailing list