[PATCH 52/53] drm/i915: Remove unwarranted clamping for hsw/bdw

Chris Wilson chris at chris-wilson.co.uk
Wed Apr 11 13:42:38 UTC 2018


We always start off at an "efficient frequency" and can let the system
autotune from there, eliminating the need to clamp the available range.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>
---
 drivers/gpu/drm/i915/intel_gt_pm.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_gt_pm.c b/drivers/gpu/drm/i915/intel_gt_pm.c
index 8ccd2a18d3b5..fa8c2f2080b2 100644
--- a/drivers/gpu/drm/i915/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/intel_gt_pm.c
@@ -2450,17 +2450,9 @@ void intel_gt_pm_init(struct drm_i915_private *i915)
 		gen5_init_gt_powersave(i915);
 
 	/* Derive initial user preferences/limits from the hardware limits */
-	rps->idle_freq = rps->min_freq_hw;
-
 	rps->max_freq_user = rps->max_freq_hw;
 	rps->min_freq_user = rps->min_freq_hw;
 
-	if (IS_HASWELL(i915) || IS_BROADWELL(i915))
-		rps->min_freq_user =
-			max_t(int,
-			      rps->efficient_freq,
-			      intel_freq_opcode(i915, 450));
-
 	/* After setting max-softlimit, find the overclock max freq */
 	if (IS_GEN6(i915) || IS_IVYBRIDGE(i915) || IS_HASWELL(i915)) {
 		u32 params = 0;
@@ -2479,6 +2471,7 @@ void intel_gt_pm_init(struct drm_i915_private *i915)
 
 	/* Finally allow us to boost to max by default */
 	rps->boost_freq = rps->max_freq_hw;
+	rps->idle_freq = rps->min_freq_hw;
 
 	rps->freq = rps->idle_freq;
 	rps->min = rps->min_freq_hw;
-- 
2.17.0



More information about the Intel-gfx-trybot mailing list