[PATCH 02/10] drm/i915: Program RPCS for Broadwell

Tvrtko Ursulin tursulin at ursulin.net
Thu Aug 30 20:52:00 UTC 2018


From: Chris Wilson <chris at chris-wilson.co.uk>

Currently we only configure the power gating for Skylake and above, but
the configuration should equally apply to Broadwell and Braswell. Even
though, there is not as much variation as for later generations, we want
to expose control over the configuration to userspace and may want to
opt out of the "always-enabled" setting.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
---
 drivers/gpu/drm/i915/intel_lrc.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 457e5c0fe520..a597746a8663 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -2485,13 +2485,6 @@ make_rpcs(struct drm_i915_private *dev_priv)
 	u8 subslices = hweight8(INTEL_INFO(dev_priv)->sseu.subslice_mask[0]);
 	u32 rpcs = 0;
 
-	/*
-	 * No explicit RPCS request is needed to ensure full
-	 * slice/subslice/EU enablement prior to Gen9.
-	*/
-	if (INTEL_GEN(dev_priv) < 9)
-		return 0;
-
 	if (IS_GEN11(dev_priv) && slices == 1 && subslices >= 4) {
 		if (GEM_WARN_ON(subslices & 1))
 			return 0;
-- 
2.17.1



More information about the Intel-gfx-trybot mailing list