[PATCH 0/3] drm/i915/icl: Add fix for TypeC legacy HPD handling

Imre Deak imre.deak at intel.com
Thu Dec 13 14:05:21 UTC 2018


This patchset adds a hotfix for TypeC legacy HPD handling. It depends on
an indirect detection method described in patch 2 and 3, which will be
replaced by a direct method once the BIOS/HW/FW team delivers a promised
SW/HW flag for this purpose.

There is no issue with the indirect method I know of, except for the DP
legacy case (as opposed to the HDMI case), where doing a modeset/DP AUX
read before the first HPD connect event will still result in mayham. But
that is already the situation now and we have a plan in place (the
direct method mentioned above), so the change is an improvement even for
the DP case.

This will leave the Thunderbolt and USB DP alternate mode HPD handling
still disfunctional, but that's another story, we have some kind of plan
to fix that too (in cooperation with the HW/FW team).

Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: José Roberto de Souza <jose.souza at intel.com>

Imre Deak (3):
  drm/i915/icl: Add a debug print for TypeC port disconnection
  drm/i915/icl: Add fix for TypeC legacy HDMI HPD handling
  drm/i915/icl: Add fix for TypeC legacy DP HPD handling

 drivers/gpu/drm/i915/intel_ddi.c | 54 +++++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/intel_dp.c  | 69 +++++++++++++++++++++++++++++-----------
 drivers/gpu/drm/i915/intel_drv.h |  5 ++-
 3 files changed, 105 insertions(+), 23 deletions(-)

-- 
2.13.2



More information about the Intel-gfx-trybot mailing list