[PATCH 65/66] drm/i915: Remove unwarranted clamping for hsw/bdw

Chris Wilson chris at chris-wilson.co.uk
Sat Jan 20 19:44:27 UTC 2018


We always start off at an "efficient frequency" and can let the system
autotune from there, eliminating the need to clamp the available range.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_gt_pm.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_gt_pm.c b/drivers/gpu/drm/i915/intel_gt_pm.c
index 6056c6805036..4e5b1c87835a 100644
--- a/drivers/gpu/drm/i915/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/intel_gt_pm.c
@@ -2269,17 +2269,9 @@ void intel_gt_pm_init(struct drm_i915_private *dev_priv)
 		gen5_init_gt_powersave(dev_priv);
 
 	/* Derive initial user preferences/limits from the hardware limits */
-	rps->idle_freq = rps->min_freq_hw;
-
 	rps->max_freq_user = rps->max_freq_hw;
 	rps->min_freq_user = rps->min_freq_hw;
 
-	if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
-		rps->min_freq_user =
-			max_t(int,
-			      rps->efficient_freq,
-			      intel_freq_opcode(dev_priv, 450));
-
 	/* After setting max-softlimit, find the overclock max freq */
 	if (IS_GEN6(dev_priv) ||
 	    IS_IVYBRIDGE(dev_priv) || IS_HASWELL(dev_priv)) {
@@ -2302,6 +2294,7 @@ void intel_gt_pm_init(struct drm_i915_private *dev_priv)
 
 	/* Finally allow us to boost to max by default */
 	rps->boost_freq = rps->max_freq_hw;
+	rps->idle_freq = rps->min_freq_hw;
 
 	rps->freq = rps->idle_freq;
 	rps->min = rps->min_freq_hw;
-- 
2.15.1



More information about the Intel-gfx-trybot mailing list