[PATCH 72/76] shmem: Support for registration of driver/file owner specific ops

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 24 21:41:47 UTC 2018

From: Akash Goel <akash.goel at intel.com>

This provides support for the drivers or shmem file owners to register
a set of callbacks, which can be invoked from the address space
operations methods implemented by shmem.  This allow the file owners to
hook into the shmem address space operations to do some extra/custom
operations in addition to the default ones.

The private_data field of address_space struct is used to store the
pointer to driver specific ops.  Currently only one ops field is defined,
which is migratepage, but can be extended on an as-needed basis.

The need for driver specific operations arises since some of the
operations (like migratepage) may not be handled completely within shmem,
so as to be effective, and would need some driver specific handling also.
Specifically, i915.ko would like to participate in migratepage().
i915.ko uses shmemfs to provide swappable backing storage for its user
objects, but when those objects are in use by the GPU it must pin the
entire object until the GPU is idle.  As a result, large chunks of memory
can be arbitrarily withdrawn from page migration, resulting in premature
out-of-memory due to fragmentation.  However, if i915.ko can receive the
migratepage() request, it can then flush the object from the GPU, remove
its pin and thus enable the migration.

Since gfx allocations are one of the major consumer of system memory, its
imperative to have such a mechanism to effectively deal with
fragmentation.  And therefore the need for such a provision for initiating
driver specific actions during address space operations.

Cc: Hugh Dickins <hughd at google.com>
Cc: linux-mm at kvack.org
Cc: linux-kernel at vger.linux.org
Signed-off-by: Sourab Gupta <sourab.gupta at intel.com>
Signed-off-by: Akash Goel <akash.goel at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
 include/linux/shmem_fs.h | 17 +++++++++++++++++
 mm/shmem.c               | 17 ++++++++++++++++-
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h
index 06b295bec00d..46d8b9243591 100644
--- a/include/linux/shmem_fs.h
+++ b/include/linux/shmem_fs.h
@@ -40,11 +40,28 @@ struct shmem_sb_info {
 	unsigned long shrinklist_len; /* Length of shrinklist */
+struct shmem_dev_info {
+	void *dev_private_data;
+	int (*dev_migratepage)(struct address_space *mapping,
+			       struct page *newpage, struct page *page,
+			       enum migrate_mode mode, void *dev_priv_data);
 static inline struct shmem_inode_info *SHMEM_I(struct inode *inode)
 	return container_of(inode, struct shmem_inode_info, vfs_inode);
+static inline int shmem_set_device_ops(struct address_space *mapping,
+				       struct shmem_dev_info *info)
+	if (mapping->private_data)
+		return -EEXIST;
+	mapping->private_data = info;
+	return 0;
  * Functions in mm/shmem.c called directly from elsewhere:
diff --git a/mm/shmem.c b/mm/shmem.c
index 7fbe67be86fa..6b1ddd571ee6 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1354,6 +1354,21 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc)
 	return 0;
+static int shmem_migratepage(struct address_space *mapping,
+			     struct page *newpage, struct page *page,
+			     enum migrate_mode mode)
+	struct shmem_dev_info *dev_info = mapping->private_data;
+	if (dev_info && dev_info->dev_migratepage)
+		return dev_info->dev_migratepage(mapping, newpage, page,
+				mode, dev_info->dev_private_data);
+	return migrate_page(mapping, newpage, page, mode);
 #if defined(CONFIG_NUMA) && defined(CONFIG_TMPFS)
 static void shmem_show_mpol(struct seq_file *seq, struct mempolicy *mpol)
@@ -3880,7 +3895,7 @@ static const struct address_space_operations shmem_aops = {
 	.write_end	= shmem_write_end,
-	.migratepage	= migrate_page,
+	.migratepage	= shmem_migratepage,
 	.error_remove_page = generic_error_remove_page,

More information about the Intel-gfx-trybot mailing list