[PATCH 01/12] drm/i915: Remove unused engine->cleanup
Michał Winiarski
michal.winiarski at intel.com
Mon Jun 18 11:32:03 UTC 2018
There's nothing there. Last vfunc got removed along with gen8 legacy
ringbuffer submission.
Signed-off-by: Michał Winiarski <michal.winiarski at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_lrc.c | 3 ---
drivers/gpu/drm/i915/intel_ringbuffer.c | 3 ---
drivers/gpu/drm/i915/intel_ringbuffer.h | 1 -
3 files changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index edb21f331eee..9286dc9059a5 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -2327,9 +2327,6 @@ void intel_logical_ring_cleanup(struct intel_engine_cs *engine)
WARN_ON((I915_READ_MODE(engine) & MODE_IDLE) == 0);
}
- if (engine->cleanup)
- engine->cleanup(engine);
-
intel_engine_cleanup_common(engine);
lrc_destroy_wa_ctx(engine);
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index e0448eff12bd..94ab151524d3 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1445,9 +1445,6 @@ void intel_engine_cleanup(struct intel_engine_cs *engine)
intel_ring_unpin(engine->buffer);
intel_ring_free(engine->buffer);
- if (engine->cleanup)
- engine->cleanup(engine);
-
intel_engine_cleanup_common(engine);
dev_priv->engine[engine->id] = NULL;
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
index a0bc7a8222b4..341accd479a2 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.h
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
@@ -489,7 +489,6 @@ struct intel_engine_cs {
* monotonic, even if not coherent.
*/
void (*irq_seqno_barrier)(struct intel_engine_cs *engine);
- void (*cleanup)(struct intel_engine_cs *engine);
/* GEN8 signal/wait table - never trust comments!
* signal to signal to signal to signal to signal to
--
2.17.1
More information about the Intel-gfx-trybot
mailing list