[PATCH 2/5] drm/crc: Don't wait for crc during CRC open

Mahesh Kumar mahesh1.kumar at intel.com
Mon Jun 18 14:02:52 UTC 2018


Don't wait for first CRC during crtc_crc_open. It avoids one frame wait
during open. If application want to wait after open call, it can use
poll/read.

Signed-off-by: Mahesh Kumar <mahesh1.kumar at intel.com>
---
 drivers/gpu/drm/drm_debugfs_crc.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
index 5af6ae4f18b7..4a4ff2500c57 100644
--- a/drivers/gpu/drm/drm_debugfs_crc.c
+++ b/drivers/gpu/drm/drm_debugfs_crc.c
@@ -203,20 +203,8 @@ static int crtc_crc_open(struct inode *inode, struct file *filep)
 
 	spin_lock_irq(&crc->lock);
 	crc->values_cnt = values_cnt;
-
-	/*
-	 * Only return once we got a first frame, so userspace doesn't have to
-	 * guess when this particular piece of HW will be ready to start
-	 * generating CRCs.
-	 */
-	ret = wait_event_interruptible_lock_irq(crc->wq,
-						crtc_crc_data_count(crc),
-						crc->lock);
 	spin_unlock_irq(&crc->lock);
 
-	if (ret)
-		goto err_disable;
-
 	return 0;
 
 err_disable:
-- 
2.16.2



More information about the Intel-gfx-trybot mailing list