[PATCH 1/4] firmware/guc: Remove USES_GUC_SUBMISSION for suspend/resume

Anusha Srivatsa anusha.srivatsa at intel.com
Fri Jun 22 00:10:03 UTC 2018


This is a test patch to see if GuC is crashing on a NULL
pointer.The CI runs with enable_guc=2 are throwing
MMIo errors.

Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
---
 drivers/gpu/drm/i915/intel_guc.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
index 1aff30b..dba9c45 100644
--- a/drivers/gpu/drm/i915/intel_guc.c
+++ b/drivers/gpu/drm/i915/intel_guc.c
@@ -217,12 +217,10 @@ static u32 guc_ctl_debug_flags(struct intel_guc *guc)
 		flags |= GUC_LOG_LEVEL_TO_VERBOSITY(level) <<
 			 GUC_LOG_VERBOSITY_SHIFT;
 
-	if (USES_GUC_SUBMISSION(guc_to_i915(guc))) {
-		u32 ads = intel_guc_ggtt_offset(guc, guc->ads_vma)
-			>> PAGE_SHIFT;
+	u32 ads = intel_guc_ggtt_offset(guc, guc->ads_vma)
+		>> PAGE_SHIFT;
 
-		flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
-	}
+	flags |= ads << GUC_ADS_ADDR_SHIFT | GUC_ADS_ENABLED;
 
 	return flags;
 }
-- 
2.7.4



More information about the Intel-gfx-trybot mailing list