[PATCH 3/4] drm/i915: Assert that the request is indeed complete when signaled from irq

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 6 13:38:02 UTC 2018


After we call dma_fence_signal(), confirm that the request was indeed
complete.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index ce16003ef048..633c18785c1e 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -1123,6 +1123,7 @@ static void notify_ring(struct intel_engine_cs *engine)
 
 	if (rq) {
 		dma_fence_signal(&rq->fence);
+		GEM_BUG_ON(!i915_request_completed(rq));
 		i915_request_put(rq);
 	}
 
-- 
2.16.2



More information about the Intel-gfx-trybot mailing list