[PATCH 2/2] drm/i915: Remove special case for power well 1/MISC_IO state verification

Imre Deak imre.deak at intel.com
Mon Nov 5 18:58:47 UTC 2018


The special casing to ignore these power wells while checking if their
HW and SW state matches can be removed now. The reason the HW enabled
state of these power wells was changing in the back of the driver is
actually a DMC FW bug.  The previous patch added a workaround for that
and so now the power well's is_enabled() hook should report the correct
state always.

Cc: Ramalingam C <ramalingam.c at intel.com>
Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
Signed-off-by: Imre Deak <imre.deak at intel.com>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index d7b3ecedbfa5..3e60969044d3 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -4035,14 +4035,6 @@ static void intel_power_domains_verify_state(struct drm_i915_private *dev_priv)
 		int domains_count;
 		bool enabled;
 
-		/*
-		 * Power wells not belonging to any domain (like the MISC_IO
-		 * and PW1 power wells) are under FW control, so ignore them,
-		 * since their state can change asynchronously.
-		 */
-		if (!power_well->desc->domains)
-			continue;
-
 		enabled = power_well->desc->ops->is_enabled(dev_priv,
 							    power_well);
 		if ((power_well->count || power_well->desc->always_on) !=
-- 
2.13.2



More information about the Intel-gfx-trybot mailing list