[PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v7)

[Bai, Guang]

Hi Jani,

I'm not sure if Imre or Paulo added the ICL codes below - They are great and can fix my HDMI hot-plug problem!

I have been struggling to fix this HDMI hot-plug customer issue for a long time and all my previous code changes failed the patchwork tests.

I'll post the code review after refactoring the commit message - I’m sure this is the right solution - There two customers waiting for the fixes.

Let me know should you have any concerns/questions.

Thanks again,
Guang

-----Original Message-----
From: Saarinen, Jani 
Sent: Wednesday, November 28, 2018 11:52 AM
To: Bai, Guang <guang.bai at intel.com>; intel-gfx-trybot at lists.freedesktop.org; Deak, Imre <imre.deak at intel.com>
Subject: RE: [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure (v7)

+ Imre.

> -----Original Message-----
> From: Intel-gfx-trybot 
> [mailto:intel-gfx-trybot-bounces at lists.freedesktop.org]
> On Behalf Of Guang Bai
> Sent: keskiviikko 28. marraskuuta 2018 20.24
> To: intel-gfx-trybot at lists.freedesktop.org
> Subject: [PATCH] drm/i915: Fix the HDMI hot plug disconnection failure 
> (v7)
> 
> On some platforms, slowly unplugging (wiggling) the HDMI cable makes 
> the kernel to believe the HDMI display still connected. This is 
> because the HDMI DDC lines are disconnected sometimes later after the hot-plug interrupt triggered.
> Use the hot plug live states to honor HDMI hot plug status in addtion 
> to access the DDC channels.
> 
> v2: Fix the formatting issue
> v3: Use connector type to apply changes to HDMI port only (James & 
> Matt)
> v4: Added debug info for testing
> v5: Try local hot-plug call for debugging purpose
> v6: Bypass edid fetch when hdmi disconnected in the midst of hot-plug
> v7: Use digital port status to decide edid fetch or not
> 
> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Chris Chiu <chiu at endlessm.com>
> Signed-off-by: Guang Bai <guang.bai at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
> b/drivers/gpu/drm/i915/intel_hdmi.c
> index e2c6a2b3e8f2..8cf7c78b8cdd 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -1929,7 +1929,7 @@ intel_hdmi_detect(struct drm_connector 
> *connector, bool force)
> 
>  	intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS);
> 
> -	if (IS_ICELAKE(dev_priv) &&
> +	if ((IS_ICELAKE(dev_priv) || IS_GEN9_BC(dev_priv)) &&
>  	    !intel_digital_port_connected(encoder))
>  		goto out;
> 
> --
> 2.17.1
> 
> _______________________________________________
> Intel-gfx-trybot mailing list
> Intel-gfx-trybot at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx-trybot