[PATCH 2/2] live_workarounds
Tvrtko Ursulin
tvrtko.ursulin at linux.intel.com
Thu Nov 29 16:27:15 UTC 2018
From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
---
.../drm/i915/selftests/intel_workarounds.c | 65 +++++++++++++++----
1 file changed, 52 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/intel_workarounds.c b/drivers/gpu/drm/i915/selftests/intel_workarounds.c
index d1a0923d2f38..35648c053c2b 100644
--- a/drivers/gpu/drm/i915/selftests/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/selftests/intel_workarounds.c
@@ -6,6 +6,7 @@
#include "../i915_selftest.h"
+#include "igt_spinner.h"
#include "igt_wedge_me.h"
#include "mock_context.h"
@@ -159,35 +160,56 @@ static int check_whitelist(const struct whitelist *w,
static int do_device_reset(struct intel_engine_cs *engine)
{
- i915_reset(engine->i915, ENGINE_MASK(engine->id), NULL);
+ i915_reset(engine->i915, ENGINE_MASK(engine->id), "live_workarounds");
return 0;
}
static int do_engine_reset(struct intel_engine_cs *engine)
{
- return i915_reset_engine(engine, NULL);
+ return i915_reset_engine(engine, "live_workarounds");
}
-static int switch_to_scratch_context(struct intel_engine_cs *engine)
+static int
+switch_to_scratch_context(struct intel_engine_cs *engine,
+ struct igt_spinner *spin)
{
struct i915_gem_context *ctx;
struct i915_request *rq;
+ int err = 0;
ctx = kernel_context(engine->i915);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
intel_runtime_pm_get(engine->i915);
- rq = i915_request_alloc(engine, ctx);
+
+ if (spin)
+ rq = igt_spinner_create_request(spin, ctx, engine, MI_NOOP);
+ else
+ rq = i915_request_alloc(engine, ctx);
+
intel_runtime_pm_put(engine->i915);
kernel_context_close(ctx);
- if (IS_ERR(rq))
- return PTR_ERR(rq);
+
+ if (IS_ERR(rq)) {
+ spin = NULL;
+ err = PTR_ERR(rq);
+ goto err;
+ }
i915_request_add(rq);
- return 0;
+ if (spin && !igt_wait_for_spinner(spin, rq)) {
+ pr_err("Spinner failed to start\n");
+ err = -ETIMEDOUT;
+ }
+
+err:
+ if (err && spin)
+ igt_spinner_end(spin);
+
+ return err;
}
static int check_whitelist_across_reset(struct intel_engine_cs *engine,
@@ -195,9 +217,20 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
const struct whitelist *w,
const char *name)
{
+ bool want_spin = reset == do_engine_reset;
struct i915_gem_context *ctx;
+ struct igt_spinner spin;
int err;
+ pr_info("Checking %d whitelisted registers (RING_NONPRIV) [%s]\n",
+ w->count, name);
+
+ if (want_spin) {
+ err = igt_spinner_init(&spin, engine->i915);
+ if (err)
+ return err;
+ }
+
ctx = kernel_context(engine->i915);
if (IS_ERR(ctx))
return PTR_ERR(ctx);
@@ -208,7 +241,7 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
goto out;
}
- err = switch_to_scratch_context(engine);
+ err = switch_to_scratch_context(engine, want_spin ? &spin : NULL);
if (err)
goto out;
@@ -218,6 +251,11 @@ static int check_whitelist_across_reset(struct intel_engine_cs *engine,
goto out;
}
+ if (want_spin) {
+ igt_spinner_end(&spin);
+ igt_spinner_fini(&spin);
+ }
+
err = check_whitelist(w, ctx, engine);
if (err) {
pr_err("Whitelist not preserved in context across %s reset!\n",
@@ -259,12 +297,9 @@ static int live_reset_whitelist(void *arg)
if (!whitelist_build(engine, &w))
return 0;
- pr_info("Checking %d whitelisted registers (RING_NONPRIV)\n", w.count);
-
- set_bit(I915_RESET_BACKOFF, &error->flags);
- set_bit(I915_RESET_ENGINE + engine->id, &error->flags);
-
if (intel_has_reset_engine(i915)) {
+ set_bit(I915_RESET_ENGINE + engine->id, &error->flags);
+
err = check_whitelist_across_reset(engine,
do_engine_reset, &w,
"engine");
@@ -273,6 +308,10 @@ static int live_reset_whitelist(void *arg)
}
if (intel_has_gpu_reset(i915)) {
+ set_bit(I915_RESET_BACKOFF, &error->flags);
+ set_bit(I915_RESET_HANDOFF, &error->flags);
+ set_bit(I915_RESET_ENGINE + engine->id, &error->flags);
+
err = check_whitelist_across_reset(engine,
do_device_reset, &w,
"device");
--
2.19.1
More information about the Intel-gfx-trybot
mailing list