[PATCH 2/3] drm/i915/dp: Restrict the link retrain workaround to external monitors

Dhinakaran Pandiyan dhinakaran.pandiyan at intel.com
Fri Sep 7 02:39:00 UTC 2018


commit 3cf71bc9904d ("drm/i915: Re-apply "Perform link quality check,
unconditionally during long pulse"")' applies a work around for monitors
that don't signal link loss. Apply this only for external displays as
eDP features like PSR when active will have the link turned off and the
driver will end up retraining the link seeeing that link is not
synchronized.

Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index ba641f08f945..3f89edb06a0b 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -5072,10 +5072,13 @@ intel_dp_full_detect(struct intel_connector *connector,
 		 */
 		status = connector_status_disconnected;
 		goto out;
-	} else {
+	}
+
+	if (!intel_dp_is_edp(intel_dp)) {
 		/*
 		 * If display is connected check link status in case link
 		 * went out of synchronization and sink did not tell us.
+		 * Restrict this workaround to external displays.
 		 */
 		struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)->base;
 
-- 
2.17.1



More information about the Intel-gfx-trybot mailing list