[PATCH 06/19] drm/i915/gt: Make deferred context allocation explicit
Chris Wilson
chris at chris-wilson.co.uk
Fri Aug 9 14:28:05 UTC 2019
Quoting Mika Kuoppala (2019-08-09 15:24:20)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> > -static int ring_context_pin(struct intel_context *ce)
> > +static int ring_context_alloc(struct intel_context *ce)
> > {
> > struct intel_engine_cs *engine = ce->engine;
> > - int err;
> >
> > /* One ringbuffer to rule them all */
> > GEM_BUG_ON(!engine->buffer);
> > ce->ring = engine->buffer;
> >
> > - if (!ce->state && engine->context_size) {
> > + if (engine->context_size) {
>
> I remember reading this patch earlier pondered this without
> looking at the function name change :)
>
> Consider warn on to check if there is lingering state
> on finding the alloc bit clear. Tho could be useless
> if the upper chains are straightforward, which
> they prolly are.
Simple enough bit of reinforcement that doesn't hurt, ok.
-Chris
More information about the Intel-gfx-trybot
mailing list