[PATCH 24/36] drm/i915: Note that horizontal panning seems fine with 5k modes on skl+

Ville Syrjala ville.syrjala at linux.intel.com
Wed Dec 18 16:10:41 UTC 2019


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

I wasn't able to make horizontal panning misbehave on a KBL when
driving a 5120x2880 mode. So unless there is some hard to hit corner
case it seems we're fine on that front.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index e0df709ca800..dbe97caf8a4e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -3359,8 +3359,8 @@ static int skl_max_plane_width(const struct drm_framebuffer *fb,
 		 * - FP16 (already limited to 4k)
 		 * - render compression (already limited to 4k)
 		 * - KVMR sprite and cursor (don't care)
-		 * - horizontal panning (TODO verify this)
-		 * - pipe and plane scaling (TODO verify this)
+		 * - horizontal panning (seems to work fine actually)
+		 * - pipe and plane scaling (already limited to 4k)
 		 */
 		if (cpp == 8)
 			return 4096;
-- 
2.23.0



More information about the Intel-gfx-trybot mailing list