[PATCH 05/10] drm/i915: Trim NEWCLIENT boosting

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 1 23:15:07 UTC 2019


Limit the NEWCLIENT boost to only give its small priority boost to fresh
clients only that have no dependencies. To preserve the subtle tweak for
compositors that start with a copy from a client, give them the small
non-preemptive WAIT boost instead.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_request.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 9ed5baf157a3..263b1fc9730c 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -968,8 +968,10 @@ void i915_request_add(struct i915_request *request)
 		 * Allow interactive/synchronous clients to jump ahead of
 		 * the bulk clients. (FQ_CODEL)
 		 */
-		if (!prev || i915_request_completed(prev))
+		if (list_empty(&request->sched.signalers_list))
 			attr.priority |= I915_PRIORITY_NEWCLIENT;
+		if (!prev || i915_request_completed(prev))
+			attr.priority |= I915_PRIORITY_WAIT;
 
 		engine->schedule(request, &attr);
 	}
-- 
2.20.1



More information about the Intel-gfx-trybot mailing list