[PATCH] Revert "ALSA: hda - Serialize codec registrations"
Chris Wilson
chris at chris-wilson.co.uk
Mon Feb 4 09:11:18 UTC 2019
This reverts commit 305a0ade180981686eec1f92aa6252a7c6ebb1cf.
---
include/sound/hda_codec.h | 1 -
sound/pci/hda/hda_bind.c | 3 +--
sound/pci/hda/hda_intel.c | 2 --
3 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/include/sound/hda_codec.h b/include/sound/hda_codec.h
index cc7c8d42d4fd..7fa48b100936 100644
--- a/include/sound/hda_codec.h
+++ b/include/sound/hda_codec.h
@@ -68,7 +68,6 @@ struct hda_bus {
unsigned int response_reset:1; /* controller was reset */
unsigned int in_reset:1; /* during reset operation */
unsigned int no_response_fallback:1; /* don't fallback at RIRB error */
- unsigned int bus_probing :1; /* during probing process */
int primary_dig_out_type; /* primary digital out PCM type */
unsigned int mixer_assigned; /* codec addr for mixer name */
diff --git a/sound/pci/hda/hda_bind.c b/sound/pci/hda/hda_bind.c
index 1ec706ced75c..9174f1b3a987 100644
--- a/sound/pci/hda/hda_bind.c
+++ b/sound/pci/hda/hda_bind.c
@@ -115,8 +115,7 @@ static int hda_codec_driver_probe(struct device *dev)
err = snd_hda_codec_build_controls(codec);
if (err < 0)
goto error_module;
- /* only register after the bus probe finished; otherwise it's racy */
- if (!codec->bus->bus_probing && codec->card->registered) {
+ if (codec->card->registered) {
err = snd_card_register(codec->card);
if (err < 0)
goto error_module;
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index e5c49003e75f..e784130ea4e0 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2185,7 +2185,6 @@ static int azx_probe_continue(struct azx *chip)
int dev = chip->dev_index;
int err;
- to_hda_bus(bus)->bus_probing = 1;
hda->probe_continued = 1;
/* bind with i915 if needed */
@@ -2270,7 +2269,6 @@ static int azx_probe_continue(struct azx *chip)
if (err < 0)
hda->init_failed = 1;
complete_all(&hda->probe_wait);
- to_hda_bus(bus)->bus_probing = 0;
return err;
}
--
2.20.1
More information about the Intel-gfx-trybot
mailing list