[PATCH 11/11] Revert "drm/i915: Disable PSR2 while getting pipe CRC"
José Roberto de Souza
jose.souza at intel.com
Tue Feb 12 18:59:08 UTC 2019
This reverts commit 2c74fe2eef7033b3b465680e0fc7a7ef6a824ccd.
---
drivers/gpu/drm/i915/i915_drv.h | 1 -
drivers/gpu/drm/i915/intel_drv.h | 1 -
drivers/gpu/drm/i915/intel_pipe_crc.c | 10 ----------
drivers/gpu/drm/i915/intel_psr.c | 23 -----------------------
4 files changed, 35 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index c24283ed0b55..058b4caa121a 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -524,7 +524,6 @@ struct i915_psr {
bool sink_not_reliable;
bool irq_aux_error;
u16 su_x_granularity;
- bool pipe_crc_enabled;
};
enum intel_pch {
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index f4b2a10d047e..3b2001f9d067 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -2102,7 +2102,6 @@ void intel_psr_short_pulse(struct intel_dp *intel_dp);
int intel_psr_wait_for_idle(const struct intel_crtc_state *new_crtc_state,
u32 *out_value);
bool intel_psr_enabled(struct intel_dp *intel_dp);
-void intel_psr_crc_prepare_or_finish(struct drm_i915_private *dev_priv, enum pipe pipe, bool prepare);
/* intel_quirks.c */
void intel_init_quirks(struct drm_i915_private *dev_priv);
diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c
index e04a232eba64..a8554dc4f196 100644
--- a/drivers/gpu/drm/i915/intel_pipe_crc.c
+++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
@@ -583,14 +583,6 @@ int intel_crtc_verify_crc_source(struct drm_crtc *crtc, const char *source_name,
return -EINVAL;
}
-static void intel_crtc_crc_prepare_or_finish(struct drm_crtc *crtc, bool prepare)
-{
- struct drm_i915_private *dev_priv = to_i915(crtc->dev);
- struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
-
- intel_psr_crc_prepare_or_finish(dev_priv, intel_crtc->pipe, prepare);
-}
-
int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name)
{
struct drm_i915_private *dev_priv = to_i915(crtc->dev);
@@ -617,8 +609,6 @@ int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name)
if (ret != 0)
goto out;
- intel_crtc_crc_prepare_or_finish(crtc, source != INTEL_PIPE_CRC_SOURCE_NONE);
-
pipe_crc->source = source;
I915_WRITE(PIPE_CRC_CTL(crtc->index), val);
POSTING_READ(PIPE_CRC_CTL(crtc->index));
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index fdeaf808a961..18c3961314ec 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -569,9 +569,6 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
return false;
}
- if (dev_priv->psr.pipe_crc_enabled)
- return false;
-
return true;
}
@@ -1283,23 +1280,3 @@ bool intel_psr_enabled(struct intel_dp *intel_dp)
return ret;
}
-
-void intel_psr_crc_prepare_or_finish(struct drm_i915_private *dev_priv, enum pipe pipe, bool prepare)
-{
- bool fastset = false;
-
- if (!CAN_PSR(dev_priv))
- return;
-
- mutex_lock(&dev_priv->psr.lock);
-
- if (dev_priv->psr.pipe == pipe) {
- dev_priv->psr.pipe_crc_enabled = prepare;
- fastset = !prepare || dev_priv->psr.psr2_enabled;
- }
-
- mutex_unlock(&dev_priv->psr.lock);
-
- if (fastset)
- intel_psr_fastset_force(dev_priv);
-}
--
2.20.1
More information about the Intel-gfx-trybot
mailing list