[PATCH 1/2] drm/i915: Do not allow unwedging following a failed driver initialisation

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 3 22:32:12 UTC 2019


If we declare the driver wedged during early initialisation, we leave
the driver in an undefined state (with respect to GEM execution). As
this leads to unexpected behaviour if we allow the user to unwedge the
device (through debugfs, and performed by igt at test start), do not.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 943569487687..a08d70752cb2 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3380,6 +3380,9 @@ bool i915_gem_unset_wedged(struct drm_i915_private *i915)
 	if (!test_bit(I915_WEDGED, &i915->gpu_error.flags))
 		return true;
 
+	if (!i915->gt.scratch) /* Never full initialised, recovery impossible */
+		return false;
+
 	GEM_TRACE("start\n");
 
 	/*
-- 
2.20.1



More information about the Intel-gfx-trybot mailing list