[PATCH 9/9] fbc debug
José Roberto de Souza
jose.souza at intel.com
Thu Jan 31 01:48:00 UTC 2019
---
drivers/gpu/drm/i915/intel_fbc.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c
index 656e684e7c9a..7e788f4dfb64 100644
--- a/drivers/gpu/drm/i915/intel_fbc.c
+++ b/drivers/gpu/drm/i915/intel_fbc.c
@@ -662,6 +662,8 @@ static void intel_fbc_update_state_cache(struct intel_crtc *crtc,
cache->vma = NULL;
cache->flags = 0;
+ DRM_DEBUG_KMS("intel_fbc_update_state_cache()\n");
+
cache->crtc.mode_flags = crtc_state->base.adjusted_mode.flags;
if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
cache->crtc.hsw_bdw_pixel_rate = crtc_state->pixel_rate;
@@ -681,16 +683,21 @@ static void intel_fbc_update_state_cache(struct intel_crtc *crtc,
cache->plane.pixel_blend_mode = plane_state->base.pixel_blend_mode;
- if (!cache->plane.visible)
+ if (!cache->plane.visible) {
+ DRM_DEBUG_KMS("\t!cache->plane.visible\n");
return;
+ }
cache->fb.format = fb->format;
cache->fb.stride = fb->pitches[0];
cache->vma = plane_state->vma;
cache->flags = plane_state->flags;
- if (WARN_ON(cache->flags & PLANE_HAS_FENCE && !cache->vma->fence))
+ if (WARN_ON(cache->flags & PLANE_HAS_FENCE && !cache->vma->fence)) {
+ DRM_DEBUG_KMS("\t&= ~PLANE_HAS_FENCEu\n");
cache->flags &= ~PLANE_HAS_FENCE;
+ }
+ DRM_DEBUG_KMS("\tcache->flags=%lu\n", cache->flags);
}
static bool intel_fbc_can_activate(struct intel_crtc *crtc)
@@ -726,13 +733,13 @@ static bool intel_fbc_can_activate(struct intel_crtc *crtc)
* by the CPU to the scanout and trigger updates to the FBC.
*
* Note that is possible for a tiled surface to be unmappable (and
- * so have no fence associated with it) due to aperture constaints
+ * so have no fence associated with it) due to aperture constraints
* at the time of pinning.
*
* FIXME with 90/270 degree rotation we should use the fence on
* the normal GTT view (the rotated view doesn't even have a
* fence). Would need changes to the FBC fence Y offset as well.
- * For now this will effecively disable FBC with 90/270 degree
+ * For now this will effectively disable FBC with 90/270 degree
* rotation.
*/
if (!(cache->flags & PLANE_HAS_FENCE)) {
--
2.20.1
More information about the Intel-gfx-trybot
mailing list