[PATCH i-g-t 07/33] cocci: Ignore opencoded min()/max() in min()/max() defines
Lyude
lyude at redhat.com
Fri Jun 7 23:07:55 UTC 2019
From: Lyude Paul <lyude at redhat.com>
You can't use min() inside min(), and vice-versa
Signed-off-by: Lyude Paul <lyude at redhat.com>
---
lib/igt.cocci | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/lib/igt.cocci b/lib/igt.cocci
index d6d564d7..8e72be55 100644
--- a/lib/igt.cocci
+++ b/lib/igt.cocci
@@ -108,29 +108,39 @@ T a, b, tmp;
- b = tmp;
+ igt_swap(a, b);
+// So we don't complain about #define min(), #define max(), etc.
+ at min_max_ignore@
+identifier i =~ "^m(in|ax)$";
+expression E;
+position p;
+@@
+#define i(...) <+...E at p...+>
+
// Replace open-coded min()
@@
+position p != min_max_ignore.p;
expression a;
expression b;
@@
(
-- ((a) < (b) ? (a) : (b))
+- ((a) < (b) ? (a) : (b at p))
+ min(a, b)
|
-- ((a) <= (b) ? (a) : (b))
+- ((a) <= (b) ? (a) : (b at p))
+ min(a, b)
)
// Replace open-coded max()
@@
+position p != min_max_ignore.p;
expression a;
expression b;
@@
(
-- ((a) > (b) ? (a) : (b))
+- ((a) > (b) ? (a) : (b at p))
+ max(a, b)
|
-- ((a) >= (b) ? (a) : (b))
+- ((a) >= (b) ? (a) : (b at p))
+ max(a, b)
)
--
2.21.0
More information about the Intel-gfx-trybot
mailing list