[PATCH 16/19] drm/i915/gt: Always call kref_init for the timeline

Chris Wilson chris at chris-wilson.co.uk
Sun Jun 23 22:59:05 UTC 2019


Always initialise the refcount, even for the embedded timelines inside
mock devices.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/intel_timeline.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c
index d05875ff2071..030bcd2249e9 100644
--- a/drivers/gpu/drm/i915/gt/intel_timeline.c
+++ b/drivers/gpu/drm/i915/gt/intel_timeline.c
@@ -222,6 +222,7 @@ int intel_timeline_init(struct intel_timeline *timeline,
 
 	timeline->gt = gt;
 
+	kref_init(&timeline->kref);
 	atomic_set(&timeline->pin_count, 0);
 
 	timeline->has_initial_breadcrumb = !hwsp;
@@ -316,8 +317,6 @@ intel_timeline_create(struct intel_gt *gt, struct i915_vma *global_hwsp)
 		return ERR_PTR(err);
 	}
 
-	kref_init(&timeline->kref);
-
 	return timeline;
 }
 
-- 
2.20.1



More information about the Intel-gfx-trybot mailing list