[PATCH 1/4] drm/i915: Nuke dram_info.valid

Ville Syrjala ville.syrjala at linux.intel.com
Mon Mar 25 10:47:46 UTC 2019


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

dram_info.valid is never checked so kill it. While at it pack
the struct a bit better.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 2 --
 drivers/gpu/drm/i915/i915_drv.h | 5 ++---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 5465b99b4392..6f7d269234e0 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1254,7 +1254,6 @@ skl_get_dram_info(struct drm_i915_private *dev_priv)
 		return -EINVAL;
 	}
 
-	dram_info->valid = true;
 	return 0;
 }
 
@@ -1406,7 +1405,6 @@ bxt_get_dram_info(struct drm_i915_private *dev_priv)
 		return -EINVAL;
 	}
 
-	dram_info->valid = true;
 	return 0;
 }
 
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 11803d485275..1ad37e57875b 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1833,11 +1833,10 @@ struct drm_i915_private {
 	} wm;
 
 	struct dram_info {
-		bool valid;
-		bool is_16gb_dimm;
+		u32 bandwidth_kbps;
 		u8 num_channels;
 		u8 ranks;
-		u32 bandwidth_kbps;
+		bool is_16gb_dimm;
 		bool symmetric_memory;
 		enum intel_dram_type {
 			INTEL_DRAM_UNKNOWN,
-- 
2.19.2



More information about the Intel-gfx-trybot mailing list