[PATCH 2/2] drm/i915: Fix MMIO init/cleanup order

Janusz Krzysztofik janusz.krzysztofik at linux.intel.com
Wed May 29 08:58:33 UTC 2019


Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 1 +
 drivers/gpu/drm/i915/i915_gem.c | 5 +----
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 8be69f84eb6d..ccc00f7eebec 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1020,6 +1020,7 @@ static void i915_driver_cleanup_mmio(struct drm_i915_private *dev_priv)
 {
 	intel_teardown_mchbar(dev_priv);
 	intel_uncore_fini_mmio(&dev_priv->uncore);
+	intel_cleanup_gt_powersave(dev_priv);
 	pci_dev_put(dev_priv->bridge_dev);
 }
 
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index c6a8e665a6ba..ea660f1effd1 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -4554,8 +4554,6 @@ int i915_gem_init(struct drm_i915_private *dev_priv)
 		goto err_context;
 	}
 
-	intel_init_gt_powersave(dev_priv);
-
 	ret = intel_uc_init(dev_priv);
 	if (ret)
 		goto err_pm;
@@ -4695,8 +4693,6 @@ void i915_gem_fini(struct drm_i915_private *dev_priv)
 
 	intel_wa_list_free(&dev_priv->gt_wa_list);
 
-	intel_cleanup_gt_powersave(dev_priv);
-
 	intel_uc_fini_misc(dev_priv);
 	i915_gem_cleanup_userptr(dev_priv);
 	i915_timelines_fini(dev_priv);
@@ -4708,6 +4704,7 @@ void i915_gem_fini(struct drm_i915_private *dev_priv)
 
 void i915_gem_init_mmio(struct drm_i915_private *i915)
 {
+	intel_init_gt_powersave(dev_priv);
 	i915_gem_sanitize(i915);
 }
 
-- 
2.21.0



More information about the Intel-gfx-trybot mailing list