[PATCH] drm/i915/dsb: Move Enable/Disable engine at get/put call.
Animesh Manna
animesh.manna at intel.com
Wed Nov 13 18:45:10 UTC 2019
Signed-off-by: Animesh Manna <animesh.manna at intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index d8ad5fe1efef..b064c613fb8e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -137,6 +137,7 @@ intel_dsb_get(struct intel_crtc *crtc)
}
dsb->vma = vma;
+ intel_dsb_enable_engine(dsb);
err:
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
return dsb;
@@ -162,6 +163,7 @@ void intel_dsb_put(struct intel_dsb *dsb)
return;
if (atomic_dec_and_test(&dsb->refcount)) {
+ intel_dsb_disable_engine(dsb);
i915_vma_unpin_and_release(&dsb->vma, I915_VMA_RELEASE_MAP);
dsb->cmd_buf = NULL;
dsb->free_pos = 0;
@@ -299,9 +301,6 @@ void intel_dsb_commit(struct intel_dsb *dsb)
if (!dsb->free_pos)
return;
- if (!intel_dsb_enable_engine(dsb))
- goto reset;
-
if (is_dsb_busy(dsb)) {
DRM_ERROR("HEAD_PTR write failed - dsb engine is busy.\n");
goto reset;
@@ -328,5 +327,4 @@ void intel_dsb_commit(struct intel_dsb *dsb)
reset:
dsb->free_pos = 0;
dsb->ins_start_offset = 0;
- intel_dsb_disable_engine(dsb);
}
--
2.22.0
More information about the Intel-gfx-trybot
mailing list