[PATCH v2 03/17] drm/i915: Use "new" instead of "oldnew" iterrator when appropriate

Ville Syrjala ville.syrjala at linux.intel.com
Tue Sep 10 16:08:05 UTC 2019


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

We don't need the old crtc state in some loops which use
for_each_oldnew_intel_crtc_in_state(). Switch over to
for_each_new_intel_crtc_in_state() instead.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 3b5275ab66cf..f597bb7f397a 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -13694,8 +13694,7 @@ static int intel_atomic_check(struct drm_device *dev,
 	if (ret)
 		goto fail;
 
-	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
-					    new_crtc_state, i) {
+	for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i) {
 		if (!needs_modeset(new_crtc_state) &&
 		    !new_crtc_state->update_pipe)
 			continue;
@@ -13715,8 +13714,7 @@ static int intel_atomic_check(struct drm_device *dev,
 	 * FIXME would probably be nice to know which crtc specifically
 	 * caused the failure, in cases where we can pinpoint it.
 	 */
-	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
-					    new_crtc_state, i)
+	for_each_new_intel_crtc_in_state(state, crtc, new_crtc_state, i)
 		intel_dump_pipe_config(new_crtc_state, state, "[failed]");
 
 	return ret;
-- 
2.21.0



More information about the Intel-gfx-trybot mailing list