[PATCH v2 13/17] drm/i915: Move put_domains into crtc_state
Ville Syrjala
ville.syrjala at linux.intel.com
Tue Sep 10 16:08:15 UTC 2019
From: Ville Syrjälä <ville.syrjala at linux.intel.com>
We'll need to defer the power domains put so collect the put_domains
in the crtc state.
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_atomic.c | 1 +
drivers/gpu/drm/i915/display/intel_display.c | 7 +++----
drivers/gpu/drm/i915/display/intel_display_types.h | 2 ++
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
index d3fb75bb9eb1..a8ce0e16a2fa 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic.c
@@ -204,6 +204,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
crtc_state->wm.need_postvbl_update = false;
crtc_state->fb_bits = 0;
crtc_state->update_planes = 0;
+ crtc_state->put_domains = 0;
return &crtc_state->base;
}
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 01ed591851e0..c95e3b7d1859 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -14025,7 +14025,6 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
struct drm_i915_private *dev_priv = to_i915(dev);
struct intel_crtc_state *new_crtc_state, *old_crtc_state;
struct intel_crtc *crtc;
- u64 put_domains[I915_MAX_PIPES] = {};
intel_wakeref_t wakeref = 0;
int i;
@@ -14041,7 +14040,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
if (needs_modeset(new_crtc_state) ||
new_crtc_state->update_pipe) {
- put_domains[crtc->pipe] =
+ new_crtc_state->put_domains =
modeset_get_crtc_power_domains(new_crtc_state);
}
}
@@ -14134,8 +14133,8 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
intel_post_plane_update(old_crtc_state);
- if (put_domains[i])
- modeset_put_power_domains(dev_priv, put_domains[i]);
+ if (new_crtc_state->put_domains)
+ modeset_put_power_domains(dev_priv, new_crtc_state->put_domains);
intel_modeset_verify_crtc(crtc, state, old_crtc_state, new_crtc_state);
}
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index d5cc4b810d9e..36da0bbe99f1 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -991,6 +991,8 @@ struct intel_crtc_state {
/* Forward Error correction State */
bool fec_enable;
+
+ u64 put_domains;
};
struct intel_crtc {
--
2.21.0
More information about the Intel-gfx-trybot
mailing list