[PATCH] drm/i915: Wait for object before pwrite

Prathap Kumar Valsan prathap.kumar.valsan at intel.com
Wed Apr 1 14:23:38 UTC 2020


Wait for fences for the object to complete before we start writing.

Signed-off-by: Prathap Kumar Valsan <prathap.kumar.valsan at intel.com>
---
 drivers/gpu/drm/i915/i915_gem.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 762b50b08d73..372bdf1ff071 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -810,12 +810,6 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
 
 	trace_i915_gem_object_pwrite(obj, args->offset, args->size);
 
-	ret = -ENODEV;
-	if (obj->ops->pwrite)
-		ret = obj->ops->pwrite(obj, args);
-	if (ret != -ENODEV)
-		goto err;
-
 	ret = i915_gem_object_wait(obj,
 				   I915_WAIT_INTERRUPTIBLE |
 				   I915_WAIT_ALL,
@@ -823,6 +817,12 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
 	if (ret)
 		goto err;
 
+	ret = -ENODEV;
+	if (obj->ops->pwrite)
+		ret = obj->ops->pwrite(obj, args);
+	if (ret != -ENODEV)
+		goto err;
+
 	ret = i915_gem_object_pin_pages(obj);
 	if (ret)
 		goto err;
-- 
2.20.1



More information about the Intel-gfx-trybot mailing list