[PATCH] drm/i915/display: make update_ref_clks vfunc mandatory
Lucas De Marchi
lucas.demarchi at intel.com
Thu Aug 13 08:40:50 UTC 2020
Commit ccc495fd7ac3 ("drm/i915: Unify the DPLL
ref clock frequency tracking") added a new vfunc in pll mgr, but made it
optional. However all platforms need a ref clk in their calculations.
Make this vfunc mandatory so it's not a silent fail but a very obvious
one.
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index 81ab975fe4f0..a0db76b01db8 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -4500,7 +4500,7 @@ void intel_dpll_readout_hw_state(struct drm_i915_private *i915)
{
int i;
- if (i915->dpll.mgr && i915->dpll.mgr->update_ref_clks)
+ if (i915->dpll.mgr)
i915->dpll.mgr->update_ref_clks(i915);
for (i = 0; i < i915->dpll.num_shared_dpll; i++)
--
2.28.0
More information about the Intel-gfx-trybot
mailing list