[PATCH 1/2] drm/i915/pmu: Don't grab wakeref when enabling events

Chris Wilson chris at chris-wilson.co.uk
Fri Dec 11 14:56:24 UTC 2020


Quoting Tvrtko Ursulin (2020-12-11 14:42:24)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Chris found a CI report which points out calling intel_runtime_pm_get from
> inside i915_pmu_enable hook is not allowed since it can be invoked from
> hard irq context. This is something we knew but forgot, so lets fix it
> once again.
> 
> We do this by syncing the internal book keeping with hardware rc6 counter
> on driver load.
> 
> v2:
>  * Always sync on parking and fully sync on init.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

Something else I noticed is that our rc6 sampling no longer interacts
with CONFIG_PM, so we can drop the ifdeffery.

This worksforme (looking at rapl doesn't so any impact from calling
__get_rc6 on park, so hopefully all good), and the init_rc6() sounds like
it should be an improvement for module reloads.
-Chris


More information about the Intel-gfx-trybot mailing list