[PATCH] drm/i915/display: Set TRANS_DDI_MODE_SELECT to default value when disabling TRANS_DDI

José Roberto de Souza jose.souza at intel.com
Fri Jan 10 22:38:28 UTC 2020


Timeout when disabling transcoder and transcoder fifo underruns are
fixed when setting TRANS_DDI_MODE_SELECT to 0(HDMI mode) during the
disable sequence.

Although BSpec disable sequence don't have this step it is a harmless
change and it is done by Windows driver.

Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index fbc13f36f76f..a276f41c6e41 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -1954,6 +1954,7 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state
 
 	val = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
 	val &= ~TRANS_DDI_FUNC_ENABLE;
+	val &= ~TRANS_DDI_MODE_SELECT_MASK;
 
 	if (INTEL_GEN(dev_priv) >= 12) {
 		if (!intel_dp_mst_is_master_trans(crtc_state))
-- 
2.24.1



More information about the Intel-gfx-trybot mailing list