[PATCH 1/5] drm/i915/guc: Don't turn on ctb_recv.is_in_error flag

Michal Wajdeczko michal.wajdeczko at intel.com
Tue Jan 14 14:50:19 UTC 2020


CTB descriptor flag "is_in_error" is used by the GuC to indicate that
it has stopped processing messages on H2G CT buffer due to some earlier
failures (like bad head/tail offsets in descriptor).

This flag is ignored by the GuC on G2H CT buffer (which is our RECV).

We can also skip error about corrupted message since we already have
similar error in other function.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
index a55c336cc5ef..b012741908bc 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
@@ -836,10 +836,4 @@ void intel_guc_ct_event_handler(struct intel_guc_ct *ct)
 		else
 			err = ct_handle_request(ct, msg);
 	} while (!err);
-
-	if (GEM_WARN_ON(err == -EPROTO)) {
-		CT_ERROR(ct, "Corrupted message: %#x\n", msg[0]);
-		ctb->desc->is_in_error = 1;
-	}
 }
-
-- 
2.19.2



More information about the Intel-gfx-trybot mailing list