[PATCH 1/2] debug
José Roberto de Souza
jose.souza at intel.com
Thu Jan 30 22:15:33 UTC 2020
---
drivers/gpu/drm/i915/display/intel_display.c | 2 ++
drivers/gpu/drm/i915/display/intel_fbc.c | 14 ++++++++++++++
2 files changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index c0e5002ce64c..6045c9203030 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -15042,6 +15042,8 @@ static void intel_update_crtc(struct intel_crtc *crtc,
struct drm_i915_private *dev_priv = to_i915(state->base.dev);
bool modeset = needs_modeset(new_crtc_state);
+ DRM_DEBUG_KMS("intel_update_crtc() crtc%c modeset=%i | fbc\n", pipe_name(crtc->pipe), modeset);
+
if (modeset) {
intel_crtc_update_active_timings(new_crtc_state);
diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index ab676c6756af..920cc5d77a9a 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -365,6 +365,8 @@ static void intel_fbc_hw_activate(struct drm_i915_private *dev_priv)
trace_intel_fbc_activate(fbc->crtc);
fbc->active = true;
+ DRM_DEBUG_KMS("intel_fbc_hw_activate pipe=%c\n", pipe_name(fbc->crtc->pipe));
+ //dump_stack();
fbc->activated = true;
if (INTEL_GEN(dev_priv) >= 7)
@@ -384,6 +386,8 @@ static void intel_fbc_hw_deactivate(struct drm_i915_private *dev_priv)
trace_intel_fbc_deactivate(fbc->crtc);
fbc->active = false;
+ DRM_DEBUG_KMS("intel_fbc_hw_deactivate pipe=%c\n", pipe_name(fbc->crtc->pipe));
+ //dump_stack();
if (INTEL_GEN(dev_priv) >= 5)
ilk_fbc_deactivate(dev_priv);
@@ -1096,9 +1100,14 @@ void intel_fbc_choose_crtc(struct drm_i915_private *dev_priv,
if (!plane->has_fbc)
continue;
+ if (!crtc)
+ DRM_DEBUG_KMS("plane%c pipe%c with NULL crtc\n", plane_name(plane->id), pipe_name(plane->pipe));
+
if (!plane_state->uapi.visible)
continue;
+ DRM_DEBUG_KMS("plane%c from pipe%c has_fbc\n", plane_name(plane->id), pipe_name(crtc->pipe));
+
crtc_state = intel_atomic_get_new_crtc_state(state, crtc);
crtc_state->enable_fbc = true;
@@ -1177,6 +1186,9 @@ void intel_fbc_enable(struct intel_atomic_state *state,
fbc->crtc = crtc;
out:
mutex_unlock(&fbc->lock);
+
+ DRM_DEBUG_KMS("intel_fbc_enable() crtc%c fbc->crtc%c\n", pipe_name(crtc->pipe), fbc->crtc ? pipe_name(fbc->crtc->pipe) : 'i');
+ //dump_stack();
}
/**
@@ -1194,6 +1206,8 @@ void intel_fbc_disable(struct intel_crtc *crtc)
if (!plane->has_fbc)
return;
+ DRM_DEBUG_KMS("intel_fbc_disable() crtc%c\n", pipe_name(crtc->pipe));
+
mutex_lock(&fbc->lock);
if (fbc->crtc == crtc)
__intel_fbc_disable(dev_priv);
--
2.25.0
More information about the Intel-gfx-trybot
mailing list