[PATCH 3/3] discard-vma
Chris Wilson
chris at chris-wilson.co.uk
Fri May 29 06:35:31 UTC 2020
---
drivers/gpu/drm/i915/i915_gem.c | 46 +++++++++++++++++++++++++++++++++
1 file changed, 46 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 921bbd4a9265..69c1e52ca254 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -878,6 +878,44 @@ void i915_gem_runtime_suspend(struct drm_i915_private *i915)
}
}
+static bool
+discard_ggtt_vma(struct i915_vma *vma, const struct i915_ggtt_view *view)
+{
+ const struct i915_ggtt_view discard = {
+ .type = I915_GGTT_VIEW_PARTIAL,
+ };
+ struct drm_i915_gem_object *obj = vma->obj;
+
+ spin_lock(&obj->vma.lock);
+ if (i915_vma_compare(vma, vma->vm, &discard)) {
+ struct rb_node *rb, **p;
+
+ rb_erase(&vma->obj_node, &obj->vma.tree);
+ vma->ggtt_view = discard;
+
+ rb = NULL;
+ p = &obj->vma.tree.rb_node;
+ while (*p) {
+ struct i915_vma *pos;
+ long cmp;
+
+ rb = *p;
+ pos = rb_entry(rb, struct i915_vma, obj_node);
+
+ cmp = i915_vma_compare(pos, vma->vm, &discard);
+ if (cmp < 0)
+ p = &rb->rb_right;
+ else
+ p = &rb->rb_left;
+ }
+ rb_link_node(&vma->obj_node, rb, p);
+ rb_insert_color(&vma->obj_node, &obj->vma.tree);
+ }
+ spin_unlock(&obj->vma.lock);
+
+ return i915_vma_compare(vma, vma->vm, view);
+}
+
struct i915_vma *
i915_gem_object_ggtt_pin(struct drm_i915_gem_object *obj,
const struct i915_ggtt_view *view,
@@ -924,6 +962,7 @@ i915_gem_object_ggtt_pin(struct drm_i915_gem_object *obj,
return ERR_PTR(-ENOSPC);
}
+new_vma:
vma = i915_vma_instance(obj, &ggtt->vm, view);
if (IS_ERR(vma))
return vma;
@@ -943,6 +982,13 @@ i915_gem_object_ggtt_pin(struct drm_i915_gem_object *obj,
}
}
+ if (i915_vma_is_pinned(vma) || i915_vma_is_active(vma)) {
+ if (discard_ggtt_vma(vma, view)) {
+ i915_vma_put(vma);
+ goto new_vma;
+ }
+ }
+
ret = i915_vma_unbind(vma);
if (ret)
goto err_put;
--
2.20.1
More information about the Intel-gfx-trybot
mailing list