[PATCH] lock_acquire_shared_recursive considered harmful

Chris Wilson chris at chris-wilson.co.uk
Wed Oct 28 14:54:19 UTC 2020


---
 drivers/gpu/drm/drm_connector.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 1913d8b4e16a..99acca2dba06 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -659,7 +659,7 @@ void drm_connector_list_iter_begin(struct drm_device *dev,
 {
 	iter->dev = dev;
 	iter->conn = NULL;
-	lock_acquire_shared_recursive(&connector_list_iter_dep_map, 0, 1, NULL, _RET_IP_);
+	//lock_acquire_shared_recursive(&connector_list_iter_dep_map, 0, 1, NULL, _RET_IP_);
 }
 EXPORT_SYMBOL(drm_connector_list_iter_begin);
 
@@ -740,7 +740,7 @@ void drm_connector_list_iter_end(struct drm_connector_list_iter *iter)
 		__drm_connector_put_safe(iter->conn);
 		spin_unlock_irqrestore(&config->connector_list_lock, flags);
 	}
-	lock_release(&connector_list_iter_dep_map, _RET_IP_);
+	//lock_release(&connector_list_iter_dep_map, _RET_IP_);
 }
 EXPORT_SYMBOL(drm_connector_list_iter_end);
 
-- 
2.20.1



More information about the Intel-gfx-trybot mailing list