[PATCH 2/2] wip: drm/i915/display: Test use fastset callback to compute PSR state

José Roberto de Souza jose.souza at intel.com
Fri Oct 30 16:22:40 UTC 2020


In the past forcing the compute during the initial commit was causing
issues, testing it again now that we have this new callback.

Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
 drivers/gpu/drm/i915/display/intel_dp.c      | 6 ++++++
 drivers/gpu/drm/i915/display/intel_psr.c     | 1 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index cddbda5303ff..23dce09fee04 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -18373,7 +18373,8 @@ int intel_modeset_init(struct drm_i915_private *i915)
 
 	intel_init_ipc(i915);
 
-	intel_psr_set_force_mode_changed(i915->psr.dp);
+	drm_info(&i915->drm, "not calling intel_psr_set_force_mode_changed\n");
+	//intel_psr_set_force_mode_changed(i915->psr.dp);
 
 	return 0;
 }
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index cf09aca7607b..3b0dbda5919a 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3778,6 +3778,12 @@ bool intel_dp_initial_fastset_check(struct intel_encoder *encoder,
 		return false;
 	}
 
+	if (CAN_PSR(i915) && intel_dp_is_edp(intel_dp)) {
+		drm_dbg_kms(&i915->drm, "Forcing full modeset to compute PSR state\n");
+		crtc_state->uapi.mode_changed = true;
+		return false;
+	}
+
 	return true;
 }
 
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index b5441f0b5b58..2477a894d3de 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1882,6 +1882,7 @@ void intel_psr_atomic_check(struct drm_connector *connector,
 	    connector->connector_type != DRM_MODE_CONNECTOR_eDP)
 		return;
 
+	drm_info(&dev_priv->drm, "**** fail intel_psr_atomic_check executed ***\n");
 	crtc_state = drm_atomic_get_new_crtc_state(new_state->state,
 						   new_state->crtc);
 	crtc_state->mode_changed = true;
-- 
2.29.1



More information about the Intel-gfx-trybot mailing list