[PATCH 5/5] HAX: drm/i915/display/psr: Add warnings

José Roberto de Souza jose.souza at intel.com
Tue Sep 15 20:43:02 UTC 2020


Add warning to check if plane_state.dst.yX == plane_state.src.yX +
plane_state.crtc_y.

Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
---
 drivers/gpu/drm/i915/display/intel_psr.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 15bc299a2b74..3d4d49f8ee71 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1187,6 +1187,19 @@ void intel_psr2_program_plane_sel_fetch(struct intel_plane *plane,
 	if (!plane_state->ctl || plane->id == PLANE_CURSOR)
 		return;
 
+	if (plane_state->uapi.dst.y1 != ((plane_state->uapi.src.y1 >> 16) + plane_state->uapi.crtc_y) ||
+	    plane_state->uapi.dst.y2 != ((plane_state->uapi.src.y2 >> 16) + plane_state->uapi.crtc_y)) {
+		drm_warn(&dev_priv->drm, "psr src { x1=%i y1=%i x2=%i y2=%i }\n",
+			 plane_state->uapi.src.x1 >> 16, plane_state->uapi.src.y1 >> 16,
+			 plane_state->uapi.src.x2 >> 16, plane_state->uapi.src.y2 >> 16);
+		drm_warn(&dev_priv->drm, "psr dst { x1=%i y1=%i x2=%i y2=%i }\n",
+			 plane_state->uapi.dst.x1, plane_state->uapi.dst.y1,
+			 plane_state->uapi.dst.x2, plane_state->uapi.dst.y2);
+		drm_warn(&dev_priv->drm, "psr crtc_x=%i crtc_y=%i crtc_w=%i crtc_h=%i\n",
+			 plane_state->uapi.crtc_x, plane_state->uapi.crtc_y,
+			 plane_state->uapi.crtc_w, plane_state->uapi.crtc_h);
+	}
+
 	val = plane_state->uapi.dst.y1 << 16 | plane_state->uapi.dst.x1;
 	intel_de_write_fw(dev_priv, PLANE_SEL_FETCH_POS(pipe, plane->id), val);
 
-- 
2.28.0



More information about the Intel-gfx-trybot mailing list